Add laser model description to docs #5397
Conversation
steindev
requested review from
BeyondEspresso,
PrometheusPi,
chillenzer and
finnolec
steindev
added
documentation
steindev
force-pushed
the
2025-06_add-laser-doc
branch
from
cff45ec to
5f2592c
Compare
chillenzer
left a comment
chillenzer
left a comment
There was a problem hiding this comment.
Sorry, wrong button. But it's very quick fixes.
|
@steindev what is the status of this PR? |
|
Updates? |
|
@steindev what is the status of this PR? |
|
Work in progress. Might come back to it this or next week. |
|
Poke |
steindev
force-pushed
the
2025-06_add-laser-doc
branch
2 times, most recently
from
72f7b11 to
4caaf07
Compare
|
@PrometheusPi @chillenzer @BeyondEspresso @finnolec Ready for review! |
PrometheusPi
left a comment
PrometheusPi
left a comment
There was a problem hiding this comment.
Only minor suggestions - rendered doc page looks good.
docs/source/models/lasers.rst
Outdated
| \mathrm e^{\imath\frac{1}{2}\arctan\frac{z}{z_{\mathrm R,y}}} | ||
| \mathrm e^{-\imath \frac{y^2 R_y^{-1}(z)}{2c}\frac{1}{\tau_0}\Omega^\prime} | ||
|
|
||
| only the last exponential depends on frequency :math:`\Omega^\prime` and needs to be taken into account in the Fourier transform. |
There was a problem hiding this comment.
is "exponential" here correct or "exponent"
|
What's the status here? Occasional green reviews and then updates again? |
|
Poke! |
|
Poke @steindev |
|
Setting this to draft to not further distract reviewers, @steindev |
Co-authored-by: Richard Pausch <[email protected]> Co-authored-by: chillenzer <[email protected]>
steindev
force-pushed
the
2025-06_add-laser-doc
branch
from
ca34f4b to
f9f6985
Compare
|
I assumed you implemented all requested changes @steindev and thus I set the status to "ready for review". If this is not the case, please revert to "draft mode" |
|
As an early Christmas present to all the people involved here, I will now -- after almost half a year -- merge this simple update of the docs! 🎉 |
chillenzer
merged commit 756d421
into
ComputationalRadiationPhysics:dev
3 participants
PR adds analytic formulas, which are the basis of the implementation of the
GaussianPulseandDispersivePulse, to the docs.I see this as a first version. Feedback is welcome!